{ "data": { "project": "yuzhifa_test_api_scr_06081500(File)", "auditDate": "Thu Jun 08 00:00:00 CST 2023", "platform": "", "language": "Solidity", "repository": null, "commit": null, "accessToken": null, "timeline": null, "exeSummary": null, "projectIssues": [ { "id": "M-01", "innerId": 0, "title": "Code Security - Unauthenticated Storage Access", "advice": "Authenticate msg.sender when crucial state variables will be updated. e.g. require(msg.sender == ...).", "alleviation": null, "category": "Code Security", "description": "Modification to state variable(s) is not restricted by authenticating msg.sender.", "headName": "M-01-Code Security - Unauthenticated Storage Access", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "77-77", "startLine": "75", "code": " /// @notice adding new user in game (nedded to use approve function in IERC20 token contract)\n /// @param _number number for msg.sender\n function participate(uint256 _number) public {\n address _msgSender = msg.sender;\n require(block.timestamp - startGame < 5 minutes, \"Game Over\");\n" } ], "location": "/GameVoting/contracts/Game.sol:77", "severity": "Medium", "status": null, "contract": "Game" }, { "id": "M-02", "innerId": 0, "title": "Code Security - Unauthenticated Storage Access", "advice": "Authenticate msg.sender when crucial state variables will be updated. e.g. require(msg.sender == ...).", "alleviation": null, "category": "Code Security", "description": "Modification to state variable(s) is not restricted by authenticating msg.sender.", "headName": "M-02-Code Security - Unauthenticated Storage Access", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "115-115", "startLine": "113", "code": "\n /// @notice getting winners\n function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n" } ], "location": "/GameVoting/contracts/Game.sol:115", "severity": "Medium", "status": null, "contract": "Game" }, { "id": "L-03", "innerId": 0, "title": "Optimization Suggestion - Clarify Return Value", "advice": "It is recommended to be clear whether the returned value is as expected, and only use one way to return the value.", "alleviation": null, "category": "Optimization Suggestion", "description": "The returned variable is specified in the function signature, but it still calls the return statement to return a local variable defined in the function body or state variable. It is necessary to clarify whether the returned value meets expectations.", "headName": "L-03-Optimization Suggestion - Clarify Return Value", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "67-67", "startLine": "65", "code": " require(LINK.balanceOf(address(this)) >= fee, \"Not enough LINK in contract\");\n randomRecived = true;\n return requestRandomness(keyHash, fee);\n }\n\n" } ], "location": "/GameVoting/contracts/Game.sol:67", "severity": "Low", "status": null, "contract": "Game" }, { "id": "I-04", "innerId": 0, "title": "Optimization Suggestion - Floating Pragma", "advice": "Use a fixed compiler version, and consider whether the bugs in the selected compiler version (https://github.com/ethereum/solidity/releases) will affect the contract.", "alleviation": null, "category": "Optimization Suggestion", "description": "Contracts should be deployed with the fixed compiler version that they have been tested thoroughly. Pinning the compiler version helps ensure that contracts are not compiled by untested compiler versions.", "headName": "I-04-Optimization Suggestion - Floating Pragma", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "2-2", "startLine": "1", "code": "// SPDX-License-Identifier: GPL-3.0\npragma solidity ^0.8.13;\n\nimport \"./Game.sol\";\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "2-2", "startLine": "1", "code": "// SPDX-License-Identifier: GPL-3.0\npragma solidity ^0.8.13;\n\nimport \"@chainlink/contracts/src/v0.8/VRFConsumerBase.sol\";\n" } ], "location": "/GameVoting/contracts/Game.sol:2,/GameVoting/contracts/GameFactory.sol:2", "severity": "Informational", "status": null, "contract": "Global" }, { "id": "I-05", "innerId": 0, "title": "Optimization Suggestion - Recommended to Follow Code layout Conventions.", "advice": "It is recommended to follow the above code layout conventions to improve code readability.", "alleviation": null, "category": "Optimization Suggestion", "description": "In the solidity document(https://docs.soliditylang.org/en/v0.8.17/style-guide.html), there are the following conventions for code layout:\nLayout contract elements in the following order: 1. Pragma statements, 2. Import statements, 3. Interfaces, 4. Libraries, 5. Contracts.\nInside each contract, library or interface, use the following order: 1. Type declarations, 2. State variables, 3. Events, 4. Modifiers, 5. Functions.\nFunctions should be grouped according to their visibility and ordered: 1. constructor, 2. receive function (if exists), 3. fallback function (if exists), 4. external, 5. public, 6. internal, 7. private.", "headName": "I-05-Optimization Suggestion - Recommended to Follow Code layout Conventions.", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "14-14", "startLine": "12", "code": "}\n\ncontract Game is VRFConsumerBase {\n\n struct Gamer {\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "6-6", "startLine": "4", "code": "import \"./Game.sol\";\n\ncontract GameFactory {\n \n event GameStarted(IERC20 token, uint256 deposit, uint256 number, uint256 numberOfUsers, address owner);\n" } ], "location": "/GameVoting/contracts/Game.sol:14,/GameVoting/contracts/GameFactory.sol:6", "severity": "Informational", "status": null, "contract": "GameFactory" }, { "id": "I-06", "innerId": 0, "title": "Optimization Suggestion - Tautology Issue", "advice": "Since inequality comparisons cost less gas than larger, it is recommended to convert uint-to-zero comparisons to uint-to-zero inequality comparisons.", "alleviation": null, "category": "Optimization Suggestion", "description": "Since inequality comparisons cost less gas than larger, it is recommended to convert uint-to-zero comparisons to uint-to-zero inequality comparisons.", "headName": "I-06-Optimization Suggestion - Tautology Issue", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "133-133", "startLine": "131", "code": " _counter = gamers[_winner].ABS;\n for (uint256 i = 0; i < id; i++) { // getting array of wiiners \n if (_counter == gamers[i].ABS && _numberOfWinners >= 0){\n _numberOfWinners > 0 ? _numberOfWinners-- : _numberOfWinners;\n winners.push(i);\n" } ], "location": "/GameVoting/contracts/Game.sol:133", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-07", "innerId": 0, "title": "Optimization Suggestion - Unused Import Contract", "advice": "It is recommended to delete unused Import contracts.", "alleviation": null, "category": "Optimization Suggestion", "description": "Import's contract is not used, which will increase gas consumption.", "headName": "I-07-Optimization Suggestion - Unused Import Contract", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "4-4", "startLine": "2", "code": "pragma solidity ^0.8.13;\n\nimport \"./Game.sol\";\n\ncontract GameFactory {\n" } ], "location": "/GameVoting/contracts/GameFactory.sol:4", "severity": "Informational", "status": null, "contract": "Global" }, { "id": "I-08", "innerId": 0, "title": "Optimization Suggestion - Use CustomError Instead of String", "advice": "When reverting, it is recommended to use CustomError instead of ordinary strings to describe the error message.", "alleviation": null, "category": "Optimization Suggestion", "description": "When using revert, using CustomError is more gas efficient than string description. Because the error message described using CustomError is only compiled into four bytes.", "headName": "I-08-Optimization Suggestion - Use CustomError Instead of String", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "64-64", "startLine": "62", "code": " /// @notice function from chainlink\n function getRandomNumber() public returns (bytes32 requestId) {\n require(!randomRecived, \"Random number recived\");\n require(LINK.balanceOf(address(this)) >= fee, \"Not enough LINK in contract\");\n randomRecived = true;\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "21-21", "startLine": "19", "code": "\n require(address(_token) != address(0), \"Wrong token address\");\n require(_deposit != 0, \"Deposit shoul be more than ZERO\");\n require (\n games[_msgSender] == address(0),\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "65-65", "startLine": "63", "code": " function getRandomNumber() public returns (bytes32 requestId) {\n require(!randomRecived, \"Random number recived\");\n require(LINK.balanceOf(address(this)) >= fee, \"Not enough LINK in contract\");\n randomRecived = true;\n return requestRandomness(keyHash, fee);\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "84-84", "startLine": "82", "code": " \"Your number should be less than 100\"\n );\n require(gamers[id].gamerAddress != _msgSender, \"You are already in game\");\n\n calculateParticipants();\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "80-80", "startLine": "78", "code": " address _msgSender = msg.sender;\n require(block.timestamp - startGame < 5 minutes, \"Game Over\");\n require(\n _number <= 100,\n \"Your number should be less than 100\"\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "20-20", "startLine": "18", "code": " address _msgSender = msg.sender;\n\n require(address(_token) != address(0), \"Wrong token address\");\n require(_deposit != 0, \"Deposit shoul be more than ZERO\");\n require (\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "22-22", "startLine": "20", "code": " require(address(_token) != address(0), \"Wrong token address\");\n require(_deposit != 0, \"Deposit shoul be more than ZERO\");\n require (\n games[_msgSender] == address(0),\n \"You can create just one game for one addreaa\"\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "117-117", "startLine": "115", "code": " function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n\n uint256 _winner;\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "79-79", "startLine": "77", "code": " function participate(uint256 _number) public {\n address _msgSender = msg.sender;\n require(block.timestamp - startGame < 5 minutes, \"Game Over\");\n require(\n _number <= 100,\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "26-26", "startLine": "24", "code": " \"You can create just one game for one addreaa\"\n );\n require(\n _number <= 100,\n \"Your number should be less or equals to 100\"\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "116-116", "startLine": "114", "code": " /// @notice getting winners\n function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "97-97", "startLine": "95", "code": " function calculateParticipants() private returns(uint256) {\n if(numberOfUsers > 0) {\n require (numberOfUsers >= id, \"Limit of gamers\");\n } \n id ++;\n" } ], "location": "/GameVoting/contracts/Game.sol:65,117,64,80,84,97,79,116,/GameVoting/contracts/GameFactory.sol:20,21,22,26", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-09", "innerId": 0, "title": "Optimization Suggestion - Long String in revert/require", "advice": "It is recommended to control the length of the string parameter in the revert/require function within 32 bytes.", "alleviation": null, "category": "Optimization Suggestion", "description": "If the string parameter in the revert/require function exceeds 32 bytes, more gas will be consumed.", "headName": "I-09-Optimization Suggestion - Long String in revert/require", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "80-80", "startLine": "78", "code": " address _msgSender = msg.sender;\n require(block.timestamp - startGame < 5 minutes, \"Game Over\");\n require(\n _number <= 100,\n \"Your number should be less than 100\"\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "22-22", "startLine": "20", "code": " require(address(_token) != address(0), \"Wrong token address\");\n require(_deposit != 0, \"Deposit shoul be more than ZERO\");\n require (\n games[_msgSender] == address(0),\n \"You can create just one game for one addreaa\"\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "26-26", "startLine": "24", "code": " \"You can create just one game for one addreaa\"\n );\n require(\n _number <= 100,\n \"Your number should be less or equals to 100\"\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "116-116", "startLine": "114", "code": " /// @notice getting winners\n function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n\n" } ], "location": "/GameVoting/contracts/Game.sol:80,116,/GameVoting/contracts/GameFactory.sol:22,26", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-10", "innerId": 0, "title": "Optimization Suggestion - Use Assembly to Check Zero Address", "advice": "It is recommended to use assembly to check zero address.", "alleviation": null, "category": "Optimization Suggestion", "description": "Using assembly to check zero address can save gas.", "headName": "I-10-Optimization Suggestion - Use Assembly to Check Zero Address", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "23-23", "startLine": "21", "code": " require(_deposit != 0, \"Deposit shoul be more than ZERO\");\n require (\n games[_msgSender] == address(0),\n \"You can create just one game for one addreaa\"\n );\n" }, { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "20-20", "startLine": "18", "code": " address _msgSender = msg.sender;\n\n require(address(_token) != address(0), \"Wrong token address\");\n require(_deposit != 0, \"Deposit shoul be more than ZERO\");\n require (\n" } ], "location": "/GameVoting/contracts/GameFactory.sol:20,23", "severity": "Informational", "status": null, "contract": "GameFactory" }, { "id": "I-11", "innerId": 0, "title": "Optimization Suggestion - Use ++i/--i instead of i++/i--", "advice": "It is recommended to use ++i/--i instead of i++/i-- in for loop.", "alleviation": null, "category": "Optimization Suggestion", "description": "Compared with i++, ++i can save about 5 gas per use.Compared with i--, --i can save about 3 gas per use in for loop.", "headName": "I-11-Optimization Suggestion - Use ++i/--i instead of i++/i--", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "132-132", "startLine": "130", "code": "\n _counter = gamers[_winner].ABS;\n for (uint256 i = 0; i < id; i++) { // getting array of wiiners \n if (_counter == gamers[i].ABS && _numberOfWinners >= 0){\n _numberOfWinners > 0 ? _numberOfWinners-- : _numberOfWinners;\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "123-123", "startLine": "121", "code": " uint256 _counter = abs(0);\n\n for (uint256 i = 0; i < id; i++) { // getting the nearest number to random number\n gamers[i].ABS = abs(i);\n if (_counter > gamers[i].ABS){\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "145-145", "startLine": "143", "code": " }\n uint256 _winnerAmount = calculateWinnerAmount();\n for (uint256 i = 0; i < winners.length; i++) { // transfering winners amount of tokens\n token.transfer(gamers[i].gamerAddress, _winnerAmount);\n emit Winner(gamers[i].gamerAddress, gamers[i].number, _winnerAmount);\n" } ], "location": "/GameVoting/contracts/Game.sol:123,145,132", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-12", "innerId": 0, "title": "Optimization Suggestion - Too Many Digits", "advice": "It is recommended to convert to a constant value, which is easier to maintain.", "alleviation": null, "category": "Optimization Suggestion", "description": "The number is too long, and it is easy to make mistakes when modifying and maintaining.", "headName": "I-12-Optimization Suggestion - Too Many Digits", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "56-56", "startLine": "54", "code": " numberOfUsers = _numberOfUsers;\n keyHash = 0x6e75b569a01ef56d18cab6a8e71e6600d6ce853834d4a5748b720d06f878b3a4;\n fee = 100000000000000; // 0.0001 LINK\n gamers[0].number = _number;\n gamers[0].gamerAddress = msg.sender;\n" } ], "location": "/GameVoting/contracts/Game.sol:56", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-13", "innerId": 0, "title": "Optimization Suggestion - Cache State Variables that are Read Multiple Times within A Function", "advice": "When a state variable is read multiple times in a function, it is recommended to use a local variable to cache the state variable.", "alleviation": null, "category": "Optimization Suggestion", "description": "When a state variable is read multiple times in a function, using a local variable to cache the state variable can avoid frequently reading data from storage, thereby saving gas.", "headName": "I-13-Optimization Suggestion - Cache State Variables that are Read Multiple Times within A Function", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "65-65", "startLine": "63", "code": " function getRandomNumber() public returns (bytes32 requestId) {\n require(!randomRecived, \"Random number recived\");\n require(LINK.balanceOf(address(this)) >= fee, \"Not enough LINK in contract\");\n randomRecived = true;\n return requestRandomness(keyHash, fee);\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "155-155", "startLine": "153", "code": " /// @notice calculating the difference between the number of gamer and random number\n function abs(uint256 i) private view returns(uint256) {\n if (gamers[i].number >= randomResult) return (gamers[i].number - randomResult);\n return (randomResult - gamers[i].number);\n}\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "117-117", "startLine": "115", "code": " function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n\n uint256 _winner;\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "116-116", "startLine": "114", "code": " /// @notice getting winners\n function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n\n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "96-96", "startLine": "94", "code": " /// @notice checking amount of users in game\n function calculateParticipants() private returns(uint256) {\n if(numberOfUsers > 0) {\n require (numberOfUsers >= id, \"Limit of gamers\");\n } \n" }, { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "97-97", "startLine": "95", "code": " function calculateParticipants() private returns(uint256) {\n if(numberOfUsers > 0) {\n require (numberOfUsers >= id, \"Limit of gamers\");\n } \n id ++;\n" } ], "location": "/GameVoting/contracts/Game.sol:155,65,96,117,97,116", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-14", "innerId": 0, "title": "Optimization Suggestion - Use != 0 Instead of > 0 for Unsigned Integer Comparison", "advice": "For unsigned integers, it is recommended to use !=0 instead of >0 for comparison.", "alleviation": null, "category": "Optimization Suggestion", "description": "For unsigned integers, use !=0 for comparison, which consumes less gas than >0.", "headName": "I-14-Optimization Suggestion - Use != 0 Instead of > 0 for Unsigned Integer Comparison", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "96-96", "startLine": "94", "code": " /// @notice checking amount of users in game\n function calculateParticipants() private returns(uint256) {\n if(numberOfUsers > 0) {\n require (numberOfUsers >= id, \"Limit of gamers\");\n } \n" } ], "location": "/GameVoting/contracts/Game.sol:96", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-15", "innerId": 0, "title": "Optimization Suggestion - Function Visibility Can Be External", "advice": "Functions that are not called in the contract should be declared as external.", "alleviation": null, "category": "Optimization Suggestion", "description": "Functions that are not called should be declared as external.", "headName": "I-15-Optimization Suggestion - Function Visibility Can Be External", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "63-63", "startLine": "61", "code": "\n /// @notice function from chainlink\n function getRandomNumber() public returns (bytes32 requestId) {\n require(!randomRecived, \"Random number recived\");\n require(LINK.balanceOf(address(this)) >= fee, \"Not enough LINK in contract\");\n" } ], "location": "/GameVoting/contracts/Game.sol:63", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-16", "innerId": 0, "title": "Optimization Suggestion - Function Visibility Can Be External", "advice": "Functions that are not called in the contract should be declared as external.", "alleviation": null, "category": "Optimization Suggestion", "description": "Functions that are not called should be declared as external.", "headName": "I-16-Optimization Suggestion - Function Visibility Can Be External", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "77-77", "startLine": "75", "code": " /// @notice adding new user in game (nedded to use approve function in IERC20 token contract)\n /// @param _number number for msg.sender\n function participate(uint256 _number) public {\n address _msgSender = msg.sender;\n require(block.timestamp - startGame < 5 minutes, \"Game Over\");\n" } ], "location": "/GameVoting/contracts/Game.sol:77", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-17", "innerId": 0, "title": "Optimization Suggestion - Function Visibility Can Be External", "advice": "Functions that are not called in the contract should be declared as external.", "alleviation": null, "category": "Optimization Suggestion", "description": "Functions that are not called should be declared as external.", "headName": "I-17-Optimization Suggestion - Function Visibility Can Be External", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "115-115", "startLine": "113", "code": "\n /// @notice getting winners\n function getWinner() public {\n require(randomResult < 101, \"You need to wait for random Number\");\n require(block.timestamp - startGame >= 5 minutes, \"Game is not Over\");\n" } ], "location": "/GameVoting/contracts/Game.sol:115", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-18", "innerId": 0, "title": "Optimization Suggestion - Function Visibility Can Be External", "advice": "Functions that are not called in the contract should be declared as external.", "alleviation": null, "category": "Optimization Suggestion", "description": "Functions that are not called should be declared as external.", "headName": "I-18-Optimization Suggestion - Function Visibility Can Be External", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/GameFactory.sol", "highLine": "17-17", "startLine": "15", "code": " /// @param _number number which selected by owner of game\n /// @param _numberOfUsers maximum number of players should be equals ZERO if you don't need a limit\n function start(IERC20 _token, uint256 _deposit, uint256 _number, uint256 _numberOfUsers) public {\n address _msgSender = msg.sender;\n\n" } ], "location": "/GameVoting/contracts/GameFactory.sol:17", "severity": "Informational", "status": null, "contract": "GameFactory" }, { "id": "I-19", "innerId": 0, "title": "Optimization Suggestion - Variables Can Be Modified with Immutable", "advice": "For contracts compiled with compiler of versions 0.6.5 and above, if the state variable is only modified in the constructor, it is recommended to modify the variable with immutable to save gas.", "alleviation": null, "category": "Optimization Suggestion", "description": "The solidity compiler of version 0.6.5 introduces immutable to modify state variables that are only modified in the constructor. Using immutable can save gas.", "headName": "I-19-Optimization Suggestion - Variables Can Be Modified with Immutable", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "23-23", "startLine": "21", "code": "\n IERC20 public token; // token for deposit in Game\n uint256 public startGame; // point in time, when game srated\n uint256 public deposit; //amount of tokens to participate in Game\n uint256 public numberOfUsers; // number of users who can participate in Game\n" } ], "location": "/GameVoting/contracts/Game.sol:23", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-20", "innerId": 0, "title": "Optimization Suggestion - Variables Can Be Modified with Immutable", "advice": "For contracts compiled with compiler of versions 0.6.5 and above, if the state variable is only modified in the constructor, it is recommended to modify the variable with immutable to save gas.", "alleviation": null, "category": "Optimization Suggestion", "description": "The solidity compiler of version 0.6.5 introduces immutable to modify state variables that are only modified in the constructor. Using immutable can save gas.", "headName": "I-20-Optimization Suggestion - Variables Can Be Modified with Immutable", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "24-24", "startLine": "22", "code": " IERC20 public token; // token for deposit in Game\n uint256 public startGame; // point in time, when game srated\n uint256 public deposit; //amount of tokens to participate in Game\n uint256 public numberOfUsers; // number of users who can participate in Game\n uint256 public id = 1; // users id\n" } ], "location": "/GameVoting/contracts/Game.sol:24", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-21", "innerId": 0, "title": "Optimization Suggestion - Variables Can Be Modified with Immutable", "advice": "For contracts compiled with compiler of versions 0.6.5 and above, if the state variable is only modified in the constructor, it is recommended to modify the variable with immutable to save gas.", "alleviation": null, "category": "Optimization Suggestion", "description": "The solidity compiler of version 0.6.5 introduces immutable to modify state variables that are only modified in the constructor. Using immutable can save gas.", "headName": "I-21-Optimization Suggestion - Variables Can Be Modified with Immutable", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "25-25", "startLine": "23", "code": " uint256 public startGame; // point in time, when game srated\n uint256 public deposit; //amount of tokens to participate in Game\n uint256 public numberOfUsers; // number of users who can participate in Game\n uint256 public id = 1; // users id\n uint constant WAD = 10 ** 18; // Decimal number with 18 digits of precision\n" } ], "location": "/GameVoting/contracts/Game.sol:25", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-22", "innerId": 0, "title": "Optimization Suggestion - Variables Can Be Modified with Immutable", "advice": "For contracts compiled with compiler of versions 0.6.5 and above, if the state variable is only modified in the constructor, it is recommended to modify the variable with immutable to save gas.", "alleviation": null, "category": "Optimization Suggestion", "description": "The solidity compiler of version 0.6.5 introduces immutable to modify state variables that are only modified in the constructor. Using immutable can save gas.", "headName": "I-22-Optimization Suggestion - Variables Can Be Modified with Immutable", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "33-33", "startLine": "31", "code": "\n bool public randomRecived; // allowing to get random number just once\n bytes32 internal keyHash; // identifies which Chainlink oracle to use\n uint256 internal fee; // fee to get random number\n uint256 private randomResult = 101; // random number\n" } ], "location": "/GameVoting/contracts/Game.sol:33", "severity": "Informational", "status": null, "contract": "Game" }, { "id": "I-23", "innerId": 0, "title": "Optimization Suggestion - Variables Can Be Modified with Immutable", "advice": "For contracts compiled with compiler of versions 0.6.5 and above, if the state variable is only modified in the constructor, it is recommended to modify the variable with immutable to save gas.", "alleviation": null, "category": "Optimization Suggestion", "description": "The solidity compiler of version 0.6.5 introduces immutable to modify state variables that are only modified in the constructor. Using immutable can save gas.", "headName": "I-23-Optimization Suggestion - Variables Can Be Modified with Immutable", "detailCodeList": [ { "sourceFileName": "/GameVoting/contracts/Game.sol", "highLine": "34-34", "startLine": "32", "code": " bool public randomRecived; // allowing to get random number just once\n bytes32 internal keyHash; // identifies which Chainlink oracle to use\n uint256 internal fee; // fee to get random number\n uint256 private randomResult = 101; // random number\n\n" } ], "location": "/GameVoting/contracts/Game.sol:34", "severity": "Informational", "status": null, "contract": "Game" } ], "files": null, "severityStats": [ { "total": 1, "issueIds": [ "L-03" ], "severity": "Low" }, { "total": 2, "issueIds": [ "M-01", "M-02" ], "severity": "Medium" }, { "total": 20, "issueIds": [ "I-04", "I-05", "I-06", "I-07", "I-08", "I-09", "I-10", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-18", "I-19", "I-20", "I-21", "I-22", "I-23" ], "severity": "Informational" } ], "fileContractStats": [ { "total": 4, "issueIds": null, "fileName": "/GameVoting/contracts/GameFactory.sol", "auditReportContractStateEntries": [ { "total": 2, "issueIds": [ "I-10", "I-18" ], "contract": "GameFactory^0", "severityDetails": [ { "total": 2, "issueIds": [ "I-10", "I-18" ], "severity": "Informational" } ] }, { "total": 2, "issueIds": [ "I-04", "I-07" ], "contract": "Global^0", "severityDetails": [ { "total": 2, "issueIds": [ "I-04", "I-07" ], "severity": "Informational" } ] } ] }, { "total": 19, "issueIds": null, "fileName": "/GameVoting/contracts/Game.sol", "auditReportContractStateEntries": [ { "total": 18, "issueIds": [ "L-03", "M-01", "M-02", "I-06", "I-08", "I-09", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-19", "I-20", "I-21", "I-22", "I-23" ], "contract": "Game^0", "severityDetails": [ { "total": 1, "issueIds": [ "L-03" ], "severity": "Low" }, { "total": 2, "issueIds": [ "M-01", "M-02" ], "severity": "Medium" }, { "total": 15, "issueIds": [ "I-06", "I-08", "I-09", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-19", "I-20", "I-21", "I-22", "I-23" ], "severity": "Informational" } ] }, { "total": 1, "issueIds": [ "I-05" ], "contract": "GameFactory^1", "severityDetails": [ { "total": 1, "issueIds": [ "I-05" ], "severity": "Informational" } ] } ] } ], "contractStats": [ { "total": 2, "issueIds": [ "I-10", "I-18" ], "contract": "GameFactory^0", "severityDetails": [ { "total": 2, "issueIds": [ "I-10", "I-18" ], "severity": "Informational" } ] }, { "total": 2, "issueIds": [ "I-04", "I-07" ], "contract": "Global^0", "severityDetails": [ { "total": 2, "issueIds": [ "I-04", "I-07" ], "severity": "Informational" } ] }, { "total": 18, "issueIds": [ "L-03", "M-01", "M-02", "I-06", "I-08", "I-09", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-19", "I-20", "I-21", "I-22", "I-23" ], "contract": "Game^0", "severityDetails": [ { "total": 1, "issueIds": [ "L-03" ], "severity": "Low" }, { "total": 2, "issueIds": [ "M-01", "M-02" ], "severity": "Medium" }, { "total": 15, "issueIds": [ "I-06", "I-08", "I-09", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-19", "I-20", "I-21", "I-22", "I-23" ], "severity": "Informational" } ] }, { "total": 1, "issueIds": [ "I-05" ], "contract": "GameFactory^1", "severityDetails": [ { "total": 1, "issueIds": [ "I-05" ], "severity": "Informational" } ] } ], "categoryStats": [ { "total": 21, "issueIds": [ "L-03", "I-04", "I-05", "I-06", "I-07", "I-08", "I-09", "I-10", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-18", "I-19", "I-20", "I-21", "I-22", "I-23" ], "category": "Optimization Suggestion", "severityDetails": [ { "total": 1, "issueIds": [ "L-03" ], "severity": "Low" }, { "total": 20, "issueIds": [ "I-04", "I-05", "I-06", "I-07", "I-08", "I-09", "I-10", "I-11", "I-12", "I-13", "I-14", "I-15", "I-16", "I-17", "I-18", "I-19", "I-20", "I-21", "I-22", "I-23" ], "severity": "Informational" } ] }, { "total": 2, "issueIds": [ "M-01", "M-02" ], "category": "Code Security", "severityDetails": [ { "total": 2, "issueIds": [ "M-01", "M-02" ], "severity": "Medium" } ] } ], "categoryCheckItemStats": [ { "total": 0, "issueIds": null, "category": "Optimization Suggestion", "checkItemStatEntries": [ { "total": 1, "issueIds": [ "I-14" ], "checkItem": "Use != 0 Instead of > 0 for Unsigned Integer Comparison" }, { "total": 1, "issueIds": [ "I-11" ], "checkItem": "Use ++i/--i instead of i++/i--" }, { "total": 1, "issueIds": [ "I-13" ], "checkItem": "Cache State Variables that are Read Multiple Times within A Function" }, { "total": 1, "issueIds": [ "I-06" ], "checkItem": "Tautology Issue" }, { "total": 5, "issueIds": [ "I-19", "I-20", "I-21", "I-22", "I-23" ], "checkItem": "Variables Can Be Modified with Immutable" }, { "total": 1, "issueIds": [ "I-08" ], "checkItem": "Use CustomError Instead of String" }, { "total": 1, "issueIds": [ "I-12" ], "checkItem": "Too Many Digits" }, { "total": 1, "issueIds": [ "I-05" ], "checkItem": "Recommended to Follow Code layout Conventions." }, { "total": 4, "issueIds": [ "I-15", "I-16", "I-17", "I-18" ], "checkItem": "Function Visibility Can Be External" }, { "total": 1, "issueIds": [ "I-07" ], "checkItem": "Unused Import Contract" }, { "total": 1, "issueIds": [ "I-04" ], "checkItem": "Floating Pragma" }, { "total": 1, "issueIds": [ "I-10" ], "checkItem": "Use Assembly to Check Zero Address" }, { "total": 1, "issueIds": [ "L-03" ], "checkItem": "Clarify Return Value" }, { "total": 1, "issueIds": [ "I-09" ], "checkItem": "Long String in revert/require" } ] }, { "total": 0, "issueIds": null, "category": "Code Security", "checkItemStatEntries": [ { "total": 2, "issueIds": [ "M-01", "M-02" ], "checkItem": "Unauthenticated Storage Access" } ] } ], "contracts": [ "Game", "GameFactory" ], "complete": true }, "success": true }